Provide a global option to enable/disable escaping of forward slashes#76
Open
najoast wants to merge 1 commit intompx:masterfrom
Open
Provide a global option to enable/disable escaping of forward slashes#76najoast wants to merge 1 commit intompx:masterfrom
najoast wants to merge 1 commit intompx:masterfrom
Conversation
mpx
reviewed
Oct 12, 2021
| static int json_escape_forward_slash(lua_State *l) | ||
| { | ||
| lua_Integer escape_forward_slash = luaL_checkinteger(l, 1); | ||
| char2escape['/'] = escape_forward_slash ? "\\/" : NULL; |
Owner
There was a problem hiding this comment.
CJSON deliberately avoids global options, everything is stored in the state.
Please move char2escape into json_config_t.
rzanol
pushed a commit
to rzanol/lua-cjson
that referenced
this pull request
Sep 21, 2023
…y 31 bits and uninitialized variable. (mpx#76) [dtoa.c:2453] -> [dtoa.c:2454]: (warning) Shifting signed 32-bit value by 31 bits is undefined behaviour. See condition at line 2453. [dtoa.c:2846]: (error) Uninitialized variable: bb [dtoa.c:2847]: (error) Uninitialized variable: bd [dtoa.c:2848]: (error) Uninitialized variable: bs [dtoa.c:2850]: (error) Uninitialized variable: delta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many people are discussing how to solve the forward slash escaping problem, which shows that this is a common demand.
For example:
#57
#66
Existing solutions are changed from escaping to non-escaping, losing flexibility.
I think it would be better to add a switch to control it, but if it is placed in cfg, when traversing characters for escaping, an additional
ifjudgment is required each time. It is better to modify thechar2escapetable directly, which has better performance.But this brings a new problem, that is, different cjson objects created by
cjson.new()will share this setting. I don't think the problem is big. Most people either turn on or off escaping. It is unlikely that different cjson objects in the same process have two requirements for escaping.This option(
escape_forward_slash) can be regarded as a global option.